-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ENOENT and TypeErrors in function-no-unknown
#5916
Conversation
This change bumps `css-functions-list` from 3.0.0 to 3.0.1. See https://github.com/niksy/css-functions-list/releases/tag/v3.0.1 ```shell npm i css-functions-list ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks also for helping resolve the issue upstream.
What's the impact of the bug btw; is it only affecting Jest test or is it generally affecting all windows users?
css-functions-list
in function-no-unknown
function-no-unknown
Probably, I think this PR will fix problems about |
Good to know. Let's release when #5914 lands so that we shore up the new rule. |
Sorry this produced errors, but I’ve been following proper way on how to handle |
Is there more to do on this issue or can we merge? |
I forgot the merge. 😅 |
Updated the changelog:
|
This change bumps
css-functions-list
from 3.0.0 to 3.0.1.See https://github.com/niksy/css-functions-list/releases/tag/v3.0.1
css-functions-list@3.0.1
improves handling paths on Windows. So, it's no longer necessary to useURL
in our code.